feat: improve grab selection labels and menu title#8
Merged
Conversation
Made-with: Cursor
V3RON
force-pushed
the
fix/native-bottom-tabs
branch
from
e88eb37 to
39a844a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves how grabbed elements are labeled in the selection menu and in the description copied from Grab.
The selection title is derived from the React owner stack, skipping generic
ViewandTextwrappers so labels read like Text (in YourComponent) instead of stopping on the inner host. When stack data is available, the description preview uses the first meaningful component name for the opening tag while still reading props from the underlying native host. The menu header title also usesadjustsFontSizeToFitwith a bounded width so long labels remain readable.